fixed Sidebar theme#1979
Conversation
|
Looks good but would love to see screenshots of all of the platforms, especially iOS. |
parasharrajat
force-pushed
the
parasharrajat/Screenwrapper
branch
from
c1e9571 to
94f7b14
Compare
|
@shawnborton Unfortunately, I don't have IOS. Here are screenshots for other platforms. As per your query, the Statusbar is transparent and its color depends on the screen below. Desktop
Mobile Web
Android
|
parasharrajat
force-pushed
the
parasharrajat/Screenwrapper
branch
3 times, most recently
from
ff32c17 to
83b16d7
Compare
parasharrajat
force-pushed
the
parasharrajat/Screenwrapper
branch
from
83b16d7 to
e8734d1
Compare
|
@Luke9389 Updated. |
|
Let me pull this down and test on iOS for you. |
|
Looks good on iOS! |
|
@parasharrajat nice work on this PR! Sorry that my reviews may have felt a bit... nit-picky. In the future, please know that if I ask a question on a review, I really don't know the answer. So don't feel like I'm asking you rhetorical questions, or that I'm hinting at something. I'll always be direct 😄. Anyway, good job, and thank you! 🙇♂️ |
|
@Luke9389. I actually like the nit-picky reviews. it helps in decision-making. Eventually, a review is a kind of second personality's point of view. So tackling all these reviews is making me good at making decisions related to code. I am sure it will help in the long run when we have to work over a lib for developers and not for consumers. 👍 |
|
@parasharrajat I will make a plan to get you paid for this PR as a bonus on your next Upwork payment 👍🏽 |
|
@laurenreidexpensify Amazing. Thanks |
|
Okay as that was merged on Tues 23 March, will pay you on 30 March as per the 7 day regression test 👍🏽 |
4 participants
Please review @marcaaron. As these changes are directly linked to your code.
Details
<SafeAreaInsetsContext.Consumer>does not have styling support but inScreenWrappercomponent was passing parent style prop to it. I have moved it to the childViewwhich is working without regression.Fixed Issues
Fixes #1967
Tested On
CC @shawnborton